Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump version to 9.0.0 #5394

Merged
merged 13 commits into from
Sep 11, 2024
Merged

Bump version to 9.0.0 #5394

merged 13 commits into from
Sep 11, 2024

Conversation

pierrehilbert
Copy link
Contributor

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pierrehilbert pierrehilbert requested review from a team as code owners September 1, 2024 15:45
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 1, 2024

This pull request does not have a backport label. Could you fix it @pierrehilbert? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Sep 1, 2024
@jlind23
Copy link
Contributor

jlind23 commented Sep 10, 2024 •
edited
Loading

@ycombinator @cmacknz our tests that rely on the previous minor fail most probably because they are looking up for a 9.X and not for 8.16 or 8.17, I think we disable them on 9.X otherwise they will continuously fail.

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 10, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@ycombinator ycombinator added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23
Copy link
Contributor

jlind23 commented Sep 11, 2024

buildkite test it

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 11, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@ycombinator
Copy link
Contributor

ycombinator commented Sep 11, 2024 •
edited
Loading

CI is failing on TestLogIngestionFleetManaged and TestLongRunningAgentForLeaks with:

[ ===] Enrolling Elastic Agent with Fleet  [8s] 
[ ===] Waiting For Enroll...  [8s] {"log.level":"info","@timestamp":"2024-09-11T12:40:29.731Z","log.origin":{"function":"github.com/elastic/elastic-agent/internal/pkg/agent/cmd.(*enrollCmd).enrollWithBackoff","file.name":"cmd/enroll_cmd.go","file.line":518},"message":"Starting enrollment to URL: https://45b285a65d42444d9b97ff10e74213f9.fleet.us-west2.gcp.elastic-cloud.com:443/","ecs.version":"1.6.0"}
        {"log.level":"info","@timestamp":"2024-09-11T12:40:30.322Z","log.origin":{"function":"github.com/elastic/elastic-agent/internal/pkg/agent/cmd.(*enrollCmd).enrollWithBackoff","file.name":"cmd/enroll_cmd.go","file.line":524},"message":"1st enrollment attempt failed, retrying enrolling to URL: https://45b285a65d42444d9b97ff10e74213f9.fleet.us-west2.gcp.elastic-cloud.com:443/ with exponential backoff (init 1s, max 10s)","ecs.version":"1.6.0"}
        Error: fail to enroll: fail to execute request to fleet-server: status code: 400, fleet-server returned an error: UnsupportedVersion, message: version is not supported
        For help, please see our troubleshooting guide at https://www.elastic.co/guide/en/fleet/9.0/fleet-troubleshooting.html
====] Failed to Enroll  [9s]

@v1v v1v removed the backport-v8.x label Sep 11, 2024
@ycombinator
Copy link
Contributor

CI errors are due to the 9.0.0-SNAPSHOT not existing yet, which is expected at this point. Force merging so we can produce an Elastic Agent 9.0.0 DRA and unified release to solve the 🐔 / 🥚 problem...

@ycombinator ycombinator merged commit dc3ee01 into main Sep 11, 2024
11 of 15 checks passed
@ycombinator ycombinator deleted the bump-version-9.0.0 branch September 11, 2024 13:45
mergify bot pushed a commit that referenced this pull request Sep 11, 2024
@pierrehilbert @mergify
Bump version to 9.0.0 (#5394)
7bea8bd 
* Bump version to 9.0.0

* Bump version to 9.0.0

* Bump version in docker/helm files

* Bump version in docker/helm files

* Bump version in docker/helm files

* Skipping TestPreviousMinor if the tested version is the first
one for the current major

* Bump version in docker/helm files

* Update manifest.go

Remove cloud-defend as it is now deprecated.

---------

Co-authored-by: Julien Lind <julien.lind@elastic.co>
(cherry picked from commit dc3ee01)
@mergify mergify bot mentioned this pull request Sep 11, 2024
Closed
7 tasks
@blakerouse blakerouse removed the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@rdner
Copy link
Member

rdner commented Sep 11, 2024 •
edited
Loading

@ycombinator merging this PR caused compatibility errors from Fleet, see https://buildkite.com/elastic/elastic-agent-extended-testing/builds/2732#0191e1d6-bbe9-44d6-8445-7c408940bde4 for examples.

Error: fail to enroll: fail to execute request to fleet-server: status code: 400, fleet-server returned an error: UnsupportedVersion, message: version is not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gizas gizas gizas approved these changes

@jlind23 jlind23 jlind23 approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis MichaelKatsoulis was automatically assigned from elastic/obs-cloudnative-monitoring

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko tetianakravchenko was automatically assigned from elastic/obs-cloudnative-monitoring

Assignees

@pierrehilbert pierrehilbert

Labels
backport-skip skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pierrehilbert @jlind23 @elasticmachine @ycombinator @rdner @gizas @v1v @blakerouse